Skip to content

P3570R2 optional variants in sender/receiver #8003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2025
Merged

P3570R2 optional variants in sender/receiver #8003

merged 1 commit into from
Jul 15, 2025

Conversation

AlisdairM
Copy link
Contributor

@AlisdairM AlisdairM force-pushed the apply_p3570_optional_variants_in_sender_receiver branch from 99d6617 to 83f7446 Compare June 23, 2025 18:12
Eisenwave
Eisenwave reviewed Jun 23, 2025
View reviewed changes
Copy link
Member

@Eisenwave Eisenwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks correct, except that there is some formatting which should be changed, perhaps separately or as a fixup here. It's only a whitespace difference anyway.

@AlisdairM
Copy link
Contributor Author

I have 3 overfull boxes that I could use help to resolve:

Error: Overfull \hbox (14.032pt too wide) in paragraph at lines 1017--1021
Error: Overfull \hbox (23.62003pt too wide) in paragraph at lines 5611--5618
Error: Overfull \hbox (14.74002pt too wide) in paragraph at lines 5611--5618

Eisenwave
Eisenwave reviewed Jun 23, 2025
View reviewed changes
@tkoeppe tkoeppe force-pushed the apply_p3570_optional_variants_in_sender_receiver branch 2 times, most recently from 833e96c to c84cced Compare July 15, 2025 23:12
@tkoeppe tkoeppe force-pushed the apply_p3570_optional_variants_in_sender_receiver branch from c84cced to 45e2170 Compare July 15, 2025 23:19
@tkoeppe tkoeppe merged commit e0eccf1 into cplusplus:main Jul 15, 2025
2 checks passed
@AlisdairM AlisdairM deleted the apply_p3570_optional_variants_in_sender_receiver branch July 17, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eisenwave Eisenwave Eisenwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2025-06 LWG Motion 18] P3570R2 optional variants in sender/receiver P3570 R1 optional variants in sender/receiver
3 participants
@AlisdairM @Eisenwave @tkoeppe